Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Markdown syntax for preprocessing docs page #3418

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

dinakazemi
Copy link
Contributor

@dinakazemi dinakazemi commented Dec 24, 2024

  • Release notes not necessary because: I think this should be part of the 1.10.5 release, but could not see an associated md file for this release

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.67%. Comparing base (09c88b1) to head (4758eb8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3418      +/-   ##
==========================================
+ Coverage   76.65%   76.67%   +0.01%     
==========================================
  Files         112      112              
  Lines       12946    12946              
==========================================
+ Hits         9924     9926       +2     
+ Misses       3022     3020       -2     

see 1 file with indirect coverage changes

@dinakazemi
Copy link
Contributor Author

Hi scanpy developers,
I wasn't sure if this change should be included as part of a milestone or not (hence the failing validation check). Could you confirm if this should be included as part of the 1.10.5 release? If so, how can I add the milestone and if not, how can I add the no-milestone label?
Thanks!

@dinakazemi dinakazemi marked this pull request as ready for review December 25, 2024 00:21
@flying-sheep flying-sheep changed the title Issue 3360 Fix Markdown syntax for preprocessing docs page Jan 9, 2025
@flying-sheep flying-sheep added this to the 1.11.0 milestone Jan 9, 2025
@flying-sheep
Copy link
Member

flying-sheep commented Jan 9, 2025

Hi! Thanks for the contribution! We’re in the process of releasing 1.11.0, and won’t make a 1.10.5 release anymore.

I added a release note using our new process documented here: https://scanpy.readthedocs.io/en/latest/dev/documentation.html#adding-to-the-docs

We should link to that page from our “making a PR” docs!

@flying-sheep flying-sheep enabled auto-merge (squash) January 9, 2025 09:42
@flying-sheep flying-sheep merged commit 5a0cc52 into scverse:main Jan 9, 2025
13 of 14 checks passed
kaushalprasadhial pushed a commit to sanchit-misra/scanpy that referenced this pull request Feb 4, 2025
Co-authored-by: Phil Schaf <flying-sheep@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix “preprocessing” docs page
2 participants