Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add tqdm dependency and remove prettier from pre-commit #57

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

thomas-reimonn
Copy link
Contributor

@thomas-reimonn thomas-reimonn commented Apr 2, 2024

This PR:

  • Adds tqdm which is a required dependency
  • Removes prettier from pre-commit, which I can't install on my system and is probably not required.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (d7b7311) to head (a40dd9f).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files           6        6           
  Lines         333      333           
=======================================
  Hits          310      310           
  Misses         23       23           

@ivirshup
Copy link
Member

ivirshup commented Apr 2, 2024

I'm going to merge this and see if we can fix the doc issues separately

@ivirshup ivirshup merged commit 9b22d05 into scverse:main Apr 2, 2024
3 of 4 checks passed
@thomas-reimonn thomas-reimonn deleted the fix/tqdm-dependency branch April 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants