Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kunming/simple batch fix #14

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

Jiangkm3
Copy link
Collaborator

Fixed the bugs in the simple batching case and add tests. Use cargo test --package whir --lib -- whir::tests::test_whir --exact --show-output to run the new batching test.

@Jiangkm3 Jiangkm3 changed the base branch from main to feat/ceno-binding-batch February 15, 2025 01:46
@Jiangkm3
Copy link
Collaborator Author

There are 3 main contributions:

  1. Added a new test for batched polynomial testing make_whir_batch_things in src/whir/mod.rs
  2. Changed the protocol of the prover so that instead of chunking the previous merkle answers by fold size, chunk by (num_polys * fold_size) to obtain each merkle answer of each polynomial
  3. Added a new compute_folds_batched for the verifier that computes the folds of evaluations of each polynomial and perform the same random linear combination as the prover.

@Jiangkm3
Copy link
Collaborator Author

It turns out that compute_folds_batched is unnecessary, instead one needs to process final_randomness_answers when there are only one round.

@yczhangsjtu yczhangsjtu merged commit e10676a into feat/ceno-binding-batch Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants