Simple batching implementation of WHIR #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark results for num vars = 20: For single polynomial:
For 64 polynomials:
|
|
For comparison with BaseFold: 1 poly:
64 polys:
|
|
With some fixes: make some loops parallel, remove an unnecessary clone. For 64 polys with 20 variables:
|
This reverts commit 9d97076.
|
Allow WHIR to process polynomials shorter than the folding factor. This is achieved by padding the short polynomial until it reaches 2^(folding_factor)
Fixed the bugs in the simple batching case and add tests. Use `cargo test --package whir --lib -- whir::tests::test_whir --exact --show-output` to run the new batching test.
…nto feat/ceno-binding-batch
yczhangsjtu
changed the title
|
After applying round-wise folding factor (specifically, 1 for first round, 4 for other rounds):
|
yczhangsjtu
force-pushed
the
feat/ceno-binding-batch
branch
from
eeb906b to
65ecef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick the batching implementation from #8 to the wrapper code