[APT-10344] Initialization State Smoothness & Bugfix #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensured that ArmadilloPlayer.armadilloStateObservable has a state as soon as the player is initialized - Fixed UnknownHostException being mapped to a HTTP status code issue rather than a Connectivity issue.
leilaramian
approved these changes
Sep 5, 2024
shreknitin89
approved these changes
Sep 5, 2024
kschults
reviewed
Sep 6, 2024
| @@ -30,9 +30,8 @@ internal fun ExoPlaybackException.toArmadilloException(): ArmadilloException { | |||
| val httpCause = source.cause as? HttpDataSource.InvalidResponseCodeException | |||
| HttpResponseCodeException(httpCause?.responseCode ?: 0, httpCause?.dataSpec?.uri.toString(), source) | |||
| } | |||
| is UnknownHostException, | |||
There was a problem hiding this comment.
The reason this was mapped to an http exception was so that we could have the host in the error for tracking. Any way to add that here?
There was a problem hiding this comment.
This exception appears in airplane mode, so it might not accurately reflect whether the host exists in DNS. Is it still valuable in that case?
There was a problem hiding this comment.
Yeah, that's a good point. It's probably fine.
kschults
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensured that ArmadilloPlayer.armadilloStateObservable has a state as soon as the player is initialized
Fixed UnknownHostException being mapped to a HTTP status code issue rather than a Connectivity issue.