Add MPEG-DASH support to playback #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryFruitman
approved these changes
Dec 6, 2023
| @@ -96,6 +96,8 @@ internal class ExoplayerDownloadEngine @Inject constructor(private val context: | |||
| return when (@C.ContentType val type = Util.inferContentType(uri)) { | |||
| C.TYPE_HLS -> | |||
| DownloadHelper.forMediaItem(context, mediaItem, renderersFactory, DefaultDataSource.Factory(context, dataSourceFactory)) | |||
| C.TYPE_DASH -> | |||
| DownloadHelper.forMediaItem(context, mediaItem, renderersFactory, DefaultDataSource.Factory(context, dataSourceFactory)) | |||
There was a problem hiding this comment.
Is DASH likely to diverge from HLS? If not, you should combine these cases.
| import javax.inject.Inject | ||
| import javax.inject.Singleton | ||
|
|
||
| @Singleton |
There was a problem hiding this comment.
Just curious what @Singleton does here? I thought it only needs to be on the provides method.
There was a problem hiding this comment.
You're probably right, but I think it's helpful to see it here to see that it's a singleton, otherwise it's hidden.
BarryFruitman
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for playback. Create new MediaSourceGenerator. Refactors some common code into a header aware helper.