Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor launcher to merge meta from parent event by default #3234

Closed
VonnyJap opened this issue Oct 29, 2024 · 0 comments
Closed

Refactor launcher to merge meta from parent event by default #3234

VonnyJap opened this issue Oct 29, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@VonnyJap
Copy link
Member

What happened:

When an event is triggered by remote pipeline, the remote build is used as the parentBuildId in the subjected build. When launcher is started, the merging of metadata occurs. During a restart case, sometimes the metadata from parentEvent is expected but with the current implementation, the metadata from parentBuildId wins over those from parentEvent, hence we will end up in a situation where some metadata are missing.

See https://github.com/screwdriver-cd/launcher/blob/8e928b64cc055140b6694bcf79a1de673f90ebfc/launch.go#L485-L514

What you expected to happen:

Metadata from parentEvent should be merged by default.

How to reproduce it:

Setup a pipeline with a remote build trigger and try to set metadata during the run of a build in a particular event, try to do a restart, it will be observed that metadata is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants