From a56c2124f2fe7b4ee1c1d6cf21ef2a35f030190e Mon Sep 17 00:00:00 2001 From: Dayanand Sagar Date: Tue, 28 Jan 2025 08:46:59 -0800 Subject: [PATCH] fix(3272): Error while creating an event with a skip message --- lib/eventFactory.js | 2 +- test/lib/eventFactory.test.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/eventFactory.js b/lib/eventFactory.js index 5346d1c0..4b930a00 100644 --- a/lib/eventFactory.js +++ b/lib/eventFactory.js @@ -925,7 +925,7 @@ class EventFactory extends BaseFactory { .then(p => { // Skip creating & starting builds if (skipMessage) { - return event; + return null; } // Start builds diff --git a/test/lib/eventFactory.test.js b/test/lib/eventFactory.test.js index 6ce82e6d..a7fe1443 100644 --- a/test/lib/eventFactory.test.js +++ b/test/lib/eventFactory.test.js @@ -943,6 +943,7 @@ describe('Event Factory', () => { return eventFactory.create(config).then(model => { assert.instanceOf(model, Event); + assert.equal(model.builds, null); assert.notCalled(jobFactoryMock.create); assert.notCalled(buildFactoryMock.create); assert.calledOnce(pipelineMock.sync);