feat(3266): make changes to models banner to include scope and scopeId #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar1312
requested changes
Jan 22, 2025
lib/bannerFactory.js
Outdated
Comment on lines
55
to
68
| if (config.scope === 'PIPELINE') { | ||
| const pipeline = await PipelineFactory.getInstance().get(config.scopeId); | ||
|
|
||
| if (!pipeline) { | ||
| throw new Error(`Pipeline ${config.scopeId} does not exist`); | ||
| } | ||
| } | ||
| if (config.scope === 'BUILD') { | ||
| const build = await BuildFactory.getInstance().get(config.scopeId); | ||
|
|
||
| if (!build) { | ||
| throw new Error(`Build ${config.scopeId} does not exist`); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we refactor the duplicate code block into a reusable function to validate the scopeId by choosing the appropriate factory based on the scope
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
sagar1312
requested changes
Jan 23, 2025
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
sagar1312
approved these changes
Jan 23, 2025
|
🎉 This PR is included in version 31.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current banner schema is implemented at a global level, lacking any concept of scope or scopeId.
Objective
There are instances where a banner is required only at the pipeline or build level. This change incorporates this concept into the banner model.
References
screwdriver-cd/screwdriver#3266
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.