fix(3272): Error while creating an event with a skip message (#640)

screwdriver-cd · Jan 28, 2025 · 7eac5d7 · 7eac5d7
1 parent 376280e
commit 7eac5d7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/eventFactory.js b/lib/eventFactory.js
@@ -925,7 +925,7 @@ class EventFactory extends BaseFactory {
                                 .then(p => {
                                     // Skip creating & starting builds
                                     if (skipMessage) {
-                                        return event;
+                                        return null;
                                     }
 
                                     // Start builds

diff --git a/test/lib/eventFactory.test.js b/test/lib/eventFactory.test.js
@@ -943,6 +943,7 @@ describe('Event Factory', () => {
 
                 return eventFactory.create(config).then(model => {
                     assert.instanceOf(model, Event);
+                    assert.equal(model.builds, null);
                     assert.notCalled(jobFactoryMock.create);
                     assert.notCalled(buildFactoryMock.create);
                     assert.calledOnce(pipelineMock.sync);