feat(3234): event and parentEvent meta should be mutually exclusive #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar1312
reviewed
Nov 5, 2024
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
tkyi
reviewed
Nov 5, 2024
Co-authored-by: Tiffany K <tiffanykyi@gmail.com>
tkyi
approved these changes
Nov 5, 2024
sagar1312
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current implementation of meta behavior causes the merging of parentEvent and event altogether whenever they are available.
Objective
This implementation should not be necessary, instead event and parentEvent meta should be mutually exclusive. The parentEvent will only be relevant for the initial build of the restart. Afterward, it will simply be part of the event, as the first build will update the event appropriately during the launcher exit.
References
screwdriver-cd/screwdriver#3234
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.