fix(3234): Always merge parent event meta last #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
force-pushed
the
mergeParentEventMeta
branch
from
2616044 to
898ebda
Compare
VonnyJap
approved these changes
Oct 30, 2024
sagar1312
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
During a restart case, sometimes the metadata from parentEvent is expected but with the current implementation, the metadata from parentBuildId wins over that from a parentEvent, ending in a situation where some metadata is missing.
Objective
This PR always merges parent event meta if it exists. Order of precedence goes: build > parent event > parent build > event
References
Related to screwdriver-cd/screwdriver#3234
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.