Add templateId and archived index to jobs table #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Sep 8, 2024
Comment on lines
21
to
32
| // eslint-disable-next-line no-unused-vars | ||
| down: async (queryInterface, Sequelize) => { | ||
| await queryInterface.sequelize.transaction(async transaction => { | ||
| await queryInterface.removeIndex(table, `${table}_templateId_archived`, { transaction }); | ||
|
|
||
| await queryInterface.addIndex(table, { | ||
| name: `${table}_templateId`, | ||
| fields: ['templateId'], | ||
| transaction | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
@tkyi
I have confirmed locally that it works fine.
I have added it for easy rollback, but I am aware that it was not in the previous migration files.
If it is not needed, we will remove it. What do you think?
There was a problem hiding this comment.
Not being absolutely necessary, I removed them according to customary practice.
tkyi
approved these changes
Sep 9, 2024
|
🎉 This PR is included in version 24.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
related screwdriver-cd/screwdriver#3191
screwdriver-cd/models#612 added archived to the job table filter in the job template metrics.
However, since the only index in the job table is
templateId, the index does not work effectively and the job template details page takes a long time to load.Objective
Create an index for
templateIdandarchivedto speed up the loading of template detail pagesReferences
screwdriver-cd/screwdriver#3191
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.