Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs on Game.map.findRoute #262

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Improve docs on Game.map.findRoute #262

merged 1 commit into from
Jan 25, 2025

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Jan 24, 2025

Brief Description

This fixes the return type of RouteOptions.routeCallback as well as document it properly. Also a slight stylistic tweak to Game.map.findRoute()'s return value.

I ran npm run compile and it did absolutely nothing. Also npm run format has a bunch of files it'd like to fix (build/concat.js).

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run compile to update index.d.ts

admon84
admon84 approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@admon84 admon84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@admon84 admon84 merged commit f924117 into screepers:master Jan 25, 2025
3 checks passed
@tiennou tiennou deleted the fix/findRoute branch February 2, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admon84 admon84 admon84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiennou @admon84