Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python requirement from ReadMe #120

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Remove Python requirement from ReadMe #120

merged 1 commit into from
Jan 30, 2020

Conversation

tcdejong
Copy link
Contributor

screeps-server-mockup is removed in #113, which relied on screeps and in turn on node-gyp, which required Python 2.
No other packages depend on Python 2. Since #113 is merged, Python 2 is no longer required for this repository.

This PR updates the repository's readme accordingly.

 `screeps-server-mockup` is removed in #113, which relied on `screeps` and in turn on `node-gyp`, which required Python 2.
No other packages depend on Python 2. Since #113 is merged, Python 2 is no longer required for this repository. 

This PR updates the repository's readme accordingly.
@tcdejong tcdejong changed the title Remove Python requirement from "Basic Usage" Remove Python requirement from ReadMe Jan 25, 2020
@pyrodogg
Copy link
Member

I merged the PR to remove screeps-server-mockup as more of a stopgap measure. I found that it really was failing to compile because it hadn't been maintained. It's dependencies have been updated and it now works with the latest screeps version.

I'd like more discussion on #117 regarding how much of a test suite should be in the starter package before continuing to remove and clean up integration testing.

In either case, it looks like node-gyp has supported Python 3 since 3.5.

@tcdejong
Copy link
Contributor Author

I'd still argue this should be merged until Python is required again, and then re-add it with correct versions mentioned. I'll go over the discussion as I see more has been said since I last checked.

@pyrodogg pyrodogg merged commit 962c62a into screepers:master Jan 30, 2020
@tcdejong tcdejong deleted the tcdejong-update-readme branch February 1, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants