Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies, especially Rollup and TypeScript #102

Open
ChristianIvicevic opened this issue Jan 1, 2019 · 3 comments
Open

Updating dependencies, especially Rollup and TypeScript #102

ChristianIvicevic opened this issue Jan 1, 2019 · 3 comments

Comments

@ChristianIvicevic
Copy link

ChristianIvicevic commented Jan 1, 2019

Are there any plans to update this package properly to the newest versions of the various dependencies? By doing so manually I noticed the following issues:

  • source-map MUST stay at 0.6.1 for the ErrorMapper to work since SourceMapConsumer has been slightly reworked.
  • Upgrading rollup to 1.0.0 will yield some deprecation warnings:
(!) rpt2 plugin: The ongenerate hook used by plugin rpt2 is deprecated. The generateBundle hook should be used instead.
(!) rpt2 plugin: The onwrite hook used by plugin rpt2 is deprecated. The generateBundle hook should be used instead.
(!) screeps plugin: The ongenerate hook used by plugin screeps is deprecated. The generateBundle hook should be used instead.
(!) screeps plugin: The onwrite hook used by plugin screeps is deprecated. The generateBundle hook should be used instead.
  • I wasn't sure whether the rpt2 or rpt3 plugin are the way to go for TypeScript 3.2+.
@TheAifam5
Copy link

@ChristianIvicevic there is also another issue with source-map:
Error: Unknown module 'fs'

fs (imported by node_modules/source-map/lib/read-wasm.js, commonjs-external:fs)
path (imported by node_modules/source-map/lib/read-wasm.js, commonjs-external:path)

@lpx1233
Copy link

lpx1233 commented May 28, 2019

@ChristianIvicevic there is also another issue with source-map:
Error: Unknown module 'fs'

fs (imported by node_modules/source-map/lib/read-wasm.js, commonjs-external:fs)
path (imported by node_modules/source-map/lib/read-wasm.js, commonjs-external:path)

Same issue here. Had to remove the usage of ErrorMapper in main.ts....

@folke
Copy link

folke commented Jan 9, 2021

The new source-map module is async only, so can't work with screeps. It needs to be pinned to =0.6.1, which is the last version that was not async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants