Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ruff #313

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Migrate to ruff #313

merged 7 commits into from
Jan 31, 2025

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Jan 30, 2025

It turns out that the best way to migrate from old-style type hints syntax is to add from __future__ import annotations, run pyugrade and only then run ruff, as pyugrade AFAIK cannot add from __future__ import annotations and ruff is more hesitant to modify the hints.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (5b202cd) to head (6734709).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   92.18%   95.13%   +2.95%     
==========================================
  Files           5        5              
  Lines         448      432      -16     
  Branches       78       74       -4     
==========================================
- Hits          413      411       -2     
+ Misses         26       13      -13     
+ Partials        9        8       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wRAR wRAR merged commit 465c42d into master Jan 31, 2025
25 checks passed
@wRAR wRAR deleted the ruff branch January 31, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants