Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop anything older than 2.13.10 #604

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Feb 23, 2024

No description provided.

Following what semanticdb has done.
@ckipp01 ckipp01 changed the title drop chore: drop anything older than 2.13.10 Feb 23, 2024
Copy link
Contributor

@jozic jozic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

bin/test-release.sh Outdated Show resolved Hide resolved
@ckipp01
Copy link
Member Author

ckipp01 commented Feb 23, 2024

Again, for context for anyone that stumbles on this, bumping your patch version should be easy in whatever context your in. SemanticDB has started to do the same for old 2.12 and 2.13 versions, so I'm just following suite. In theory we don't need to do this, but it's the easier option than refactoring certain module to not use scalafix/semanticdb. It didn't cause an issue last time, so hopefully the same goes for this.

@ckipp01 ckipp01 merged commit fd6a7c7 into scoverage:main Feb 23, 2024
53 checks passed
@ckipp01 ckipp01 deleted the drop branch February 23, 2024 13:03
@mihaisoloi
Copy link

@ckipp01 I don't know what I'm doing wrong but when I tried bumping Scala to 2.13.13 I can only get it to work with scoverage 2.0.11 and not 2.1.0 due to this error. I'm using sbt 1.9.9, not sure why it's saying it needs it for sbt 1.0
image

@ckipp01
Copy link
Member Author

ckipp01 commented Mar 1, 2024

@ckipp01 I don't know what I'm doing wrong but when I tried bumping Scala to 2.13.13 I can only get it to work with scoverage 2.0.11 and not 2.1.0 due to this error. I'm using sbt 1.9.9, not sure why it's saying it needs it for sbt 1.0 image

Keep in mind that you'll simply want to bump your sbt-scoverage version, and the latest is 2.0.11. This version of the sbt plugin will bring in the latest version of the compiler plugins, which is 2.1.0. So don't be confused by that.

@mihaisoloi
Copy link

that was it, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants