-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Simple text-based config #328
Comments
Moonfire having a text-based config file would also be very convenient for the NVR system I'm working on, which wraps Moonfire and uses it as the recording backend. It would be a lot easier to automatically configure Moonfire if it just took a config file. |
I'm skeptical of going this route. In particular, regarding these modes:
How would these modes work if the database is inconsistent with the config file? Moonfire has a very different design than Frigate with stricter ideas of database integrity. For example, each camera has an internal id (used in the SQLite database and sample file directories) and a uuid. If a user changes one or both between runs, what is expected to happen?
It certainly would be possible to have a "dump current config to a nice format" operation.
I do want to get rid of this in favor of providing only a config HTTP API (and a web UI on top of it).
I'd love to hear more about your system sometime. I would certainly like such things to be possible atop the API. |
Currently
moonfire-nvr
has a mix of a config file and then more config in the DB.It would be great if all config could optionally be done declaratively in a text file.
This make it easier to:
frigate
config, it would be great to be able to do this with Moonfire as wellmoonfire-nvr run --config myconfig.toml
with a single invocation, no separateinit
orconfig
calls needed; they'd be done automatically; no need to navigatecurses
UIs (I appreciate that it's a cool feature that's nice for some groups of users, but many others might find the "just invoke 1 binary on 1 config file" approach even easier)I understand that you also want to provide the feature to change settings, cameras, etc. via an API. For that, a DB is of course more suitable than a read-only configuration text file.
For that I propose to control the behaviour with some options:
The text was updated successfully, but these errors were encountered: