add User tests for UserManager.py #868

carpecodeum · 2020-01-22T08:08:25Z

Description

added tests for adding, removing and updatinng both normal and regular user for UserManager.py

#851

Motivation and Context

this will enhance testing for existing helper functions

after integrating with testing.mysqld

the existing tests

in UserManager.py

How Has This Been Tested?

Screenshots (In case of UI changes):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

carpecodeum · 2020-01-22T08:14:42Z

@JaDogg please review this and tell me any necessary changes that need to be made in further tests. Also for writing future tests I was thinking of making a mock db. Please give your suggestions.

JaDogg · 2020-01-22T10:28:15Z

components/core/tests/User_tests.py

+class Test(unittest.TestCase):
+
+    def test_check_existing_username(self):
+        self.assertEqual(True,check_user_name('rand'))


Can you use something like PyCharm's auto formatter to format these files.

okay i will do that!

JaDogg · 2020-01-22T10:33:14Z

@JaDogg please review this and tell me any necessary changes that need to be made in further tests. Also for writing future tests I was thinking of making a mock db. Please give your suggestions.

We can do this in few ways:

Use an ORM like PonyORM or SQLAlchemy (SQLAlchemy has migrations so I'd pick that) & use an SQLite (memory) DB for testing.
Just spin a docker image for testing. (We can also probably use dunner for this) - so the DB is created and discarded.

JaDogg · 2020-01-22T10:34:14Z

ui/package.json

@@ -42,7 +42,11 @@
    }
  ],
  "dependencies": {
-    "jasmine-core": "^2.5.2"
+    "fsevents": "^2.1.2",
+    "gyp": "^0.5.0",


why did the package.json changed for python tests?

these have come during the setup of the frontend. these packages were somewhat required to complete the setup otherwise a few errors were flashing. any suggestions are most welcome.

carpecodeum · 2020-01-22T11:01:03Z

@JaDogg please review this and tell me any necessary changes that need to be made in further tests. Also for writing future tests I was thinking of making a mock db. Please give your suggestions.

We can do this in few ways:

Use an ORM like PonyORM or SQLAlchemy (SQLAlchemy has migrations so I'd pick that) & use an SQLite (memory) DB for testing.

Just spin a docker image for testing. (We can also probably use dunner for this) - so the DB is created and discarded.

we can also checkout testing.mysqld module it automatically setups a mysqld instance in a temporary directory, and destroys it after testing. what are your thoughts?

JaDogg · 2020-01-22T17:43:13Z

@JaDogg please review this and tell me any necessary changes that need to be made in further tests. Also for writing future tests I was thinking of making a mock db. Please give your suggestions.

We can do this in few ways:

Use an ORM like PonyORM or SQLAlchemy (SQLAlchemy has migrations so I'd pick that) & use an SQLite (memory) DB for testing.

Just spin a docker image for testing. (We can also probably use dunner for this) - so the DB is created and discarded.

we can also checkout testing.mysqld module it automatically setups a mysqld instance in a temporary directory, and destroys it after testing. what are your thoughts?

Will that work in Travis-CI 🤔 if so go ahead.

carpecodeum · 2020-01-30T11:58:15Z

@JaDogg I have integrated testing.mysqld module and it passes the travis-CI test given your permission I will implement this on the upcoming and the existing tests

JaDogg

Can you change the file to user_tests.py

JaDogg · 2020-01-30T15:23:14Z

components/core/tests/User_tests.py

+import testing.mysqld
+
+# Generate Mysqld class which shares the generated database
+Mysqld = testing.mysqld.MysqldFactory(cache_initialized_db=True)


Change this to MYSQLD

Okay I will!

carpecodeum · 2020-01-30T16:44:16Z

Can you change the file to user_tests.py

Sure!

…test.py

carpecodeum · 2020-01-31T13:44:44Z

@JaDogg can you please help me with something I am not able to pass the token generated from the login test function inside a test class to subsequent test functions. Please suggest me away to to that.

carpecodeum · 2020-02-04T19:08:29Z

@JaDogg I have added a few changes that make the running of tests look better and more manageable and elaborate.

carpecodeum · 2020-03-16T22:13:58Z

@JaDogg Can you please tell me if there are any issues with this pr or is it good enough to be approved?

deshankoswatte · 2020-04-01T12:28:35Z

components/core/tests/user_test.py

+import Models
+
+
+import unittest


Duplicate import statement. Same as in line no:4.

deshankoswatte · 2020-04-01T12:29:32Z

components/core/tests/login_test.py

+    suite = unittest.TestLoader().loadTestsFromTestCase(Test)
+    unittest.TextTestRunner(verbosity=2).run(suite)
+
+


Unwanted new line.

add User tests for UserManager.py

d592f53

carpecodeum requested a review from JaDogg January 22, 2020 08:13

JaDogg reviewed Jan 22, 2020

View reviewed changes

JaDogg requested a review from kmehant January 22, 2020 10:33

JaDogg requested changes Jan 22, 2020

View reviewed changes

reformatted code

f3b8d50

add testing.mysqld module to create mock database for testing

613ee6c

carpecodeum requested a review from JaDogg January 30, 2020 12:00

JaDogg requested changes Jan 30, 2020

View reviewed changes

add testing.mysqld to existing tests and change name of file to user_…

38843f8

…test.py

JaDogg previously approved these changes Feb 2, 2020

View reviewed changes

refined test running message

44c033d

carpecodeum dismissed JaDogg’s stale review via 44c033d February 4, 2020 19:05

fixed error in naming loadfromtestcase

14807b2

deshankoswatte reviewed Apr 1, 2020

View reviewed changes

components/core/tests/user_test.py

import Models

import unittest

Copy link

deshankoswatte Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate import statement. Same as in line no:4.

deshankoswatte reviewed Apr 1, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add User tests for UserManager.py #868

add User tests for UserManager.py #868

carpecodeum commented Jan 22, 2020 •

edited

Loading

carpecodeum commented Jan 22, 2020

JaDogg Jan 22, 2020

carpecodeum Jan 22, 2020

JaDogg commented Jan 22, 2020

JaDogg Jan 22, 2020

carpecodeum Jan 22, 2020

carpecodeum commented Jan 22, 2020

JaDogg commented Jan 22, 2020

carpecodeum commented Jan 30, 2020

JaDogg left a comment

JaDogg Jan 30, 2020

carpecodeum Jan 30, 2020

carpecodeum commented Jan 30, 2020

carpecodeum commented Jan 31, 2020

carpecodeum commented Feb 4, 2020

carpecodeum commented Mar 16, 2020

deshankoswatte Apr 1, 2020

deshankoswatte Apr 1, 2020

		suite = unittest.TestLoader().loadTestsFromTestCase(Test)
		unittest.TextTestRunner(verbosity=2).run(suite)

add User tests for UserManager.py #868

Are you sure you want to change the base?

add User tests for UserManager.py #868

Conversation

carpecodeum commented Jan 22, 2020 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (In case of UI changes):

Types of changes

Checklist:

carpecodeum commented Jan 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JaDogg commented Jan 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carpecodeum commented Jan 22, 2020

JaDogg commented Jan 22, 2020

carpecodeum commented Jan 30, 2020

JaDogg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carpecodeum commented Jan 30, 2020

carpecodeum commented Jan 31, 2020

carpecodeum commented Feb 4, 2020

carpecodeum commented Mar 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carpecodeum commented Jan 22, 2020 •

edited

Loading