Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support eval scripting commands #49

Merged
merged 1 commit into from
Sep 4, 2024
Merged

support eval scripting commands #49

merged 1 commit into from
Sep 4, 2024

Conversation

72squared
Copy link
Collaborator

We should discuss this one. I really hate the Lettuce API ... not sure or not whether we should break from it but this is going to be very inconvenient for scala programmers to work with and not at all intuitive. That said, at least I got it working.

@72squared 72squared requested a review from scoquelin September 3, 2024 15:25
@scoquelin
Copy link
Owner

I used to refer to this other lib : https://github.com/profunktor/redis4cats/blob/6fcd86e62a42cf1a73f1cdc514b169c77cdb3472/modules/effects/src/main/scala/dev/profunktor/redis4cats/algebra/scripts.scala#L24 as they also had to go through many hoops to workaround the Lettuce API for some cases ...

@72squared 72squared force-pushed the jl-scripting-poc branch 2 times, most recently from eb5c7d0 to f774a78 Compare September 3, 2024 20:30
@72squared
Copy link
Collaborator Author

I used to refer to this other lib : https://github.com/profunktor/redis4cats/blob/6fcd86e62a42cf1a73f1cdc514b169c77cdb3472/modules/effects/src/main/scala/dev/profunktor/redis4cats/algebra/scripts.scala#L24 as they also had to go through many hoops to workaround the Lettuce API for some cases ...

Yep. good hints in there. I made some changes that clean some of it up. Probably need a way to clean up the response types a little more but it is better than it was.

@72squared
Copy link
Collaborator Author

This should address issue #42

@72squared 72squared self-assigned this Sep 4, 2024
Copy link
Owner

@scoquelin scoquelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@72squared 72squared changed the title support eval scripting commands (poc) support eval scripting commands Sep 4, 2024
@72squared 72squared merged commit b4fe04d into main Sep 4, 2024
3 checks passed
@72squared 72squared deleted the jl-scripting-poc branch September 4, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants