Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Commit

Permalink
(change) make the code bonito with eslint --fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sckv committed Apr 28, 2020
1 parent 3bdd544 commit c1318d6
Show file tree
Hide file tree
Showing 47 changed files with 118 additions and 76 deletions.
89 changes: 42 additions & 47 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,63 +1,58 @@
module.exports = {
env: {
node: true,
es6: true,
},
root: true,
parser: "@typescript-eslint/parser",
plugins: ["@typescript-eslint", "@typescript-eslint/tslint", "import"],
parser: '@typescript-eslint/parser',
plugins: ['@typescript-eslint', 'import'],
extends: [
"eslint:recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended",
"prettier/@typescript-eslint",
"plugin:import/errors",
"plugin:import/warnings",
"plugin:import/typescript",
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'prettier/@typescript-eslint',
'plugin:import/errors',
'plugin:import/warnings',
// 'plugin:import/typescript',
],
rules: {
"max-classes-per-file": ["error", 1],
"no-console": 0,
"no-new": 0,
"no-nested-ternary": 0,
"no-unused-vars": ["error", { varsIgnorePattern: "^_" }],
"no-underscore-dangle": 0,
"array-callback-return": 1,
"no-return-assign": 0,
"no-param-reassign": 0,
"global-require": 0,
'max-classes-per-file': ['error', 1],
'no-console': 0,
'no-new': 0,
'no-nested-ternary': 0,
'no-unused-vars': ['error', { varsIgnorePattern: '^_' }],
'no-underscore-dangle': 0,
'array-callback-return': 1,
'no-return-assign': 0,
'no-param-reassign': 0,
'global-require': 0,
// TS
"@typescript-eslint/no-var-requires": 0,
"@typescript-eslint/no-explicit-any": 0,
"@typescript-eslint/no-empty-function": 0,
"@typescript-eslint/generic-type-naming": 0,
"@typescript-eslint/explicit-function-return-type": 0,
"@typescript-eslint/prefer-namespace-keyword": 0,
"@typescript-eslint/no-non-null-assertion": 0,
"@typescript-eslint/no-use-before-define": 0,
'@typescript-eslint/no-var-requires': 0,
'@typescript-eslint/no-explicit-any': 0,
'@typescript-eslint/no-empty-function': 0,
'@typescript-eslint/generic-type-naming': 0,
'@typescript-eslint/explicit-function-return-type': 0,
'@typescript-eslint/prefer-namespace-keyword': 0,
'@typescript-eslint/no-non-null-assertion': 0,
'@typescript-eslint/no-use-before-define': 0,
'@typescript-eslint/camelcase': 0,
// IMPORT
"import/prefer-default-export": 0,
"import/no-dynamic-require": 0,
"import/named": 2,
"import/namespace": 2,
"import/default": 2,
"import/export": 2,
"import/no-unresolved": 0,
"import/order": [
"error",
'import/prefer-default-export': 0,
'import/no-dynamic-require': 0,
'import/named': 2,
'import/namespace': 2,
'import/default': 2,
'import/export': 2,
'import/no-unresolved': 0,
'import/order': [
'error',
{
"newlines-between": "always",
groups: [
"external",
"internal",
"index",
"sibling",
"parent",
"builtin",
],
'newlines-between': 'always',
groups: ['external', 'internal', 'index', 'sibling', 'parent', 'builtin'],
},
],
"import/no-extraneous-dependencies": [
"error",
'import/no-extraneous-dependencies': [
'error',
{
devDependencies: true,
optionalDependencies: false,
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
"author": "Konstantin Knyazev <konstantinknyazev@outlook.com>",
"license": "MIT",
"private": true,
"scripts": {
"format": "eslint . --fix --ext ts --ignore-pattern **/node_modules/**"
},
"workspaces": [
"./packages/accounting",
"./packages/graphql",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import e from 'express';

import { CreateAccountCommand } from '../commands/CreateAccount.command';

import { isDomainError } from '~app/tools';
import { Email } from '~app/domain/value-objects/Email.vo';
import { CreateAccountCommand } from '../commands/CreateAccount.command';
import { Account } from '~app/domain/entities/Account.ent';

interface Deps {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import e from 'express';

import { RetrieveAccountBalanceQuery } from '../queries/RetrieveAccountBalance.query';

import { isDomainError } from '~app/tools';
import { Email } from '~app/domain/value-objects/Email.vo';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { ChargePaymentCommand } from '../commands/ChargePayment.command';
import { Msg } from 'ts-nats';

import { ChargePaymentCommand } from '../commands/ChargePayment.command';

import { Email } from '~app/domain/value-objects/Email.vo';

interface Deps {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Knex from 'knex';

import { Email } from '../value-objects/Email.vo';
import { Account } from '../entities/Account.ent';
import Knex from 'knex';

export abstract class AccountManagementService {
constructor(protected database: Knex) {}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Knex from 'knex';

import { Account } from '~app/domain/entities/Account.ent';
import { AccountManagementService } from '~app/domain/services/AccountManagement.service';
import Knex from 'knex';
import { Email } from '~app/domain/value-objects/Email.vo';

export class AccountManagementServiceRepository extends AccountManagementService {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { InvoicingService } from '~app/domain/services/Invoicing.service';
import { Client } from 'ts-nats';

import { InvoicingService } from '~app/domain/services/Invoicing.service';

export class InvoicingServiceRepository extends InvoicingService {
constructor(nats: Promise<Client>) {
super(nats);
Expand Down
3 changes: 2 additions & 1 deletion packages/accounting/bootstrap/express.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ex } from '~external/express';
import { retrieveAccountBalanceController, createAccountController } from './bootstrap';

import { ex } from '~external/express';

// ASSOC ROUTES
ex.route('/balance/:email').get(retrieveAccountBalanceController.handle.bind(retrieveAccountBalanceController));
ex.route('/accounts').post(createAccountController.handle.bind(createAccountController));
Expand Down
4 changes: 3 additions & 1 deletion packages/accounting/bootstrap/queue.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { nats } from '~external/nats';
import { Client } from 'ts-nats';

import { chargePaymentHandler } from './bootstrap';

import { nats } from '~external/nats';

const bootstrapNats = async () => {
const client = (await nats) as Client;

Expand Down
1 change: 1 addition & 0 deletions packages/accounting/external/db/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import knex from 'knex';

import { options } from './knexfile';

export const database = knex(options);
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import e from 'express';

import { RetrieveInvoicesQuery } from '../queries/RetrieveInvoices.query';

import { isDomainError } from '~app/tools';
import { Email } from '~app/domain/value-objects/Email.vo';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { Msg } from 'ts-nats';

import { CreateInvoiceCommand } from '../commands/CreateInvoice.command';

import { Invoice } from '~app/domain/entities/Invoice.ent';
import { Msg } from 'ts-nats';
import { Email } from '~app/domain/value-objects/Email.vo';

interface Deps {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { PayInvoiceCommand } from '../commands/PayInvoice.command';
import { Msg } from 'ts-nats';

import { PayInvoiceCommand } from '../commands/PayInvoice.command';

interface Deps {
payInvoice: PayInvoiceCommand;
}
Expand Down
1 change: 1 addition & 0 deletions packages/billing/app/domain/entities/Invoice.ent.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as uuid from 'uuid';

import { Email } from '../value-objects/Email.vo';

type WannabeInvoice = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Invoice } from '~app/domain/entities/Invoice.ent';
import { Client } from 'ts-nats';

import { Invoice } from '~app/domain/entities/Invoice.ent';

export abstract class BalanceRelatedService {
constructor(protected nats: Promise<Client>) {}
abstract async paymentCharge(invoice: Invoice): Promise<{ isEmitted: boolean } | Error>;
Expand Down
3 changes: 2 additions & 1 deletion packages/billing/app/domain/services/Invoicing.service.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import Knex from 'knex';

import { Invoice } from '~app/domain/entities/Invoice.ent';
import { Email } from '~app/domain/value-objects/Email.vo';

import Knex from 'knex';

export abstract class InvoicingService {
constructor(protected db: Knex) {}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Client } from 'ts-nats';

import { Invoice } from '~app/domain/entities/Invoice.ent';
import { BalanceRelatedService } from '~app/domain/services/BalanceRealated.service';
import { Client } from 'ts-nats';

export class BalanceRelatedServiceRepository extends BalanceRelatedService {
constructor(nats: Promise<Client>) {
Expand Down
3 changes: 2 additions & 1 deletion packages/billing/app/infrastructure/Invoicing.repository.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Knex from 'knex';

import { InvoicingService } from '~app/domain/services/Invoicing.service';
import { Invoice } from '~app/domain/entities/Invoice.ent';
import Knex from 'knex';
import { Email } from '~app/domain/value-objects/Email.vo';

export class InvoicingServiceRepository extends InvoicingService {
Expand Down
3 changes: 0 additions & 3 deletions packages/billing/bootstrap/bootstrap.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
// REPOSITORIES
import { InvoicingServiceRepository } from '~app/infrastructure/Invoicing.repository';
import { BalanceRelatedServiceRepository } from '~app/infrastructure/BalanceRelated.repository';

// HANDLERS & CONTROLLERS
import { CreateInvoiceHandler } from '~app/application/handlers/CreateInvoice.handler';
import { PayInvoiceHandler } from '~app/application/handlers/PayInvoice.handler';
import { RetrieveInvoicesController } from '~app/application/controllers/RetrieveInvoices.controller';

// COMMANDS & QUERIES
import { PayInvoiceCommand } from '~app/application/commands/PayInvoice.command';
import { CreateInvoiceCommand } from '~app/application/commands/CreateInvoice.command';
import { RetrieveInvoicesQuery } from '~app/application/queries/RetrieveInvoices.query';

// EXTERNALS
import { database } from '~external/db';
import { nats } from '~external/nats';
Expand Down
3 changes: 2 additions & 1 deletion packages/billing/bootstrap/express.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ex } from '~external/express';
import { retrieveInvoiceController } from './bootstrap';

import { ex } from '~external/express';

// ASSOC ROUTES
ex.route('/invoices/:email').get(retrieveInvoiceController.handle.bind(retrieveInvoiceController));

Expand Down
4 changes: 3 additions & 1 deletion packages/billing/bootstrap/queue.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { nats } from '~external/nats';
import { Client } from 'ts-nats';

import { createInvoiceHandler, payInvoiceHandler } from './bootstrap';

import { nats } from '~external/nats';

const bootstrapNats = async () => {
const client = (await nats) as Client;

Expand Down
1 change: 1 addition & 0 deletions packages/billing/external/db/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import knex from 'knex';

import { options } from './knexfile';

export const database = knex(options);
1 change: 1 addition & 0 deletions packages/graphql/src/schema/Mutation.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { schemaComposer } from 'graphql-compose';

import { Account } from './Account';
import { Order } from './Order';

Expand Down
1 change: 1 addition & 0 deletions packages/graphql/src/schema/Order.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { schemaComposer } from 'graphql-compose';

import { Product } from './Product';

export const Order = schemaComposer.createObjectTC({
Expand Down
1 change: 1 addition & 0 deletions packages/graphql/src/schema/Query.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { schemaComposer } from 'graphql-compose';

import { Order } from './Order';
import { Product } from './Product';
import { Account } from './Account';
Expand Down
1 change: 1 addition & 0 deletions packages/graphql/src/server.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ApolloServer } from 'apollo-server';

import { schema } from './schema';
import { dataSources } from './http';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import e from 'express';

import { isDomainError } from '~app/tools';
import { GetSingleOrderQuery } from '../queries/GetSingleOrder.query';

import { isDomainError } from '~app/tools';

interface Deps {
getSingleOrderQuery: GetSingleOrderQuery;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import e from 'express';

import { PlaceOrderCommand } from '../commands/PlaceOrder.command';

import { Order } from '~app/domain/entities/Order.ent';
import { OrderItem } from '~app/domain/value-objects/OrderItem.vo';
import { DataForInvoice } from '~app/domain/value-objects/InvoiceData.ent';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import e from 'express';

import { isDomainError } from '~app/tools';
import { RetrieveOrdersQuery } from '../queries/RetrieveOrders.query';

import { isDomainError } from '~app/tools';
import { Email } from '~app/domain/value-objects/Email.vo';

interface Deps {
Expand Down
1 change: 1 addition & 0 deletions packages/ordering/app/domain/entities/Order.ent.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as uuid from 'uuid';

import { OrderItem } from '../value-objects/OrderItem.vo';
import { Email } from '../value-objects/Email.vo';

Expand Down
1 change: 1 addition & 0 deletions packages/ordering/app/domain/services/Invoicing.service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Client } from 'ts-nats';

import { DataForInvoice } from '../value-objects/InvoiceData.ent';

export abstract class InvoicingService {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Knex from 'knex';

import { Order } from '../entities/Order.ent';
import { Email } from '../value-objects/Email.vo';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import { Client } from 'ts-nats';
import { Fetcher } from '~external/http';

import { OrderItem } from '../value-objects/OrderItem.vo';

import { Fetcher } from '~external/http';


export abstract class OrderProductsOperationsService {
constructor(protected nats: Promise<Client>, protected http: Fetcher) {}
abstract async updateProductsStock(orderItems: OrderItem[]): Promise<{ stocksUpdated: boolean } | Error>;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Client } from 'ts-nats';

import { InvoicingService } from '~app/domain/services/Invoicing.service';
import { DataForInvoice } from '~app/domain/value-objects/InvoiceData.ent';

Expand Down
Loading

0 comments on commit c1318d6

Please sign in to comment.