Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label.py #433

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update label.py #433

wants to merge 4 commits into from

Conversation

ruelasvh
Copy link

Remove hard-coded lumi for loc==4

@andrzejnovak
Copy link
Member

Thanks @ruelasvh. Can you also mod the failing test such that it shows the behaviour when lumi number is supplied?

@ruelasvh
Copy link
Author

ruelasvh commented Jul 13, 2023

Thanks @ruelasvh. Can you also mod the failing test such that it shows the behaviour when lumi number is supplied?

Hi @andrzejnovak I've updated the MR. I needed to add a fix for the default 13 TeV com. Now the tests should be passing.

ruelasvh and others added 3 commits August 16, 2023 14:08
Remove hard-coded lumi for loc==4
Correctly format com and lumi
@jonas-eschle
Copy link
Contributor

Hi @ruelasvh , what is the status of this? Can you maybe just rebase? Are there more changes to come?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants