Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scorers dict from deep methods to DeepDASolver #186

Open
YanisLalou opened this issue Oct 24, 2024 · 0 comments
Open

Move scorers dict from deep methods to DeepDASolver #186

YanisLalou opened this issue Oct 24, 2024 · 0 comments

Comments

@YanisLalou
Copy link
Collaborator

Currently, each deep method implementation defines its own criterions dictionary with the same scorers. This leads to code duplication.

Task:

  • Move scorers dict to DeepDASolver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YanisLalou