Fix: avoid accidental load of unnecessary Xcode setting lines #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation grep-ed "CONFIGURATION", therefore it captured any lines that contain the word, not just the line starting with "CONFIGURATION=". This commit fixes the behavior so it only captures "CONFIGURATION=" line. Same change is applied to all keywords.
shoamano83
commented
Jul 4, 2024
| @@ -332,16 +332,16 @@ __load_xcode_build_settings () { | |||
| s/$/'/; | |||
| " | \ | |||
| grep \ | |||
| -e "CONFIGURATION\|INFOPLIST_PATH\|PRODUCT_SETTINGS_PATH\|SRCROOT"\ | |||
There was a problem hiding this comment.
Let me double check the intention of original implementation ... was this to capture the line CONFIGURATION= only, or was this meant to capture other lines such as CONFIGURATION_BUILD_DIR= and PODS_CONFIGURATION_BUILD_DIR= ?
There was a problem hiding this comment.
Yes it was, relax uses only CONFIGURATION environment variable, not other variables including the word 👍
There was a problem hiding this comment.
OK, and thank you!
|
Thank you so much. This PR makes sense. Unfortunately, CI jobs are failed because they are too old to work on the current GitHub Actions environment. However it should work correctly after this change and then I merged this into the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation grep-ed "CONFIGURATION", therefore it captured any lines that contain the word, not just the line starting with
CONFIGURATION=. This PR fixes the issue so that relax now capturesCONFIGURATION=line only.Background: we faced a weird build issue where Swift compilation failed after I added
line in project.pbxproj file. Looking at the code, I noticed that relax captured this setting and exported it, which caused Xcode to use wrong
OTHER_SWIFT_FLAGSoption.