Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existential-any for Swift6 #639

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

kitwtnb
Copy link

@kitwtnb kitwtnb commented Jul 15, 2024

Added any to each protocols to resolve existential-any build errors on Swift 6.
https://github.com/swiftlang/swift-evolution/blob/main/proposals/0335-existential-any.md

@scenee
Copy link
Owner

scenee commented Jul 19, 2024

Thanks for your PR. This is no problem for Swift 6, but we need to consider the support versions of Swift.
I'm planning to support Swift 6 on swift-6 branch which will bump up the minimum support Swift version, Xcode and iOS, and then will be released in v2.9.0 or v3.0.0,

I'm welcome this PR's target branch to swift-6 branch. a862b4d should be ok just for the branch.
And then if you would, I'm happy to change SWIFT_UPCOMING_FEATURE_EXISTENTIAL_ANY = YES; in the FloatingPanel project file.

@kitwtnb kitwtnb force-pushed the fix-existential-any branch from 7be6a0f to d6ad75e Compare July 23, 2024 05:56
@kitwtnb kitwtnb changed the base branch from master to swift-6 July 23, 2024 05:57
@kitwtnb
Copy link
Author

kitwtnb commented Jul 23, 2024

Rebase on swift-6 branch and change target branch to swift-6.
Also added upcoming feature to the project file.

@scenee
Copy link
Owner

scenee commented Aug 5, 2024

Thanks for your work.

@scenee scenee merged commit da31639 into scenee:swift-6 Aug 5, 2024
8 of 21 checks passed
@kitwtnb kitwtnb deleted the fix-existential-any branch August 12, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants