From 30cda71b70f5768109a005e378dd803165e07e9f Mon Sep 17 00:00:00 2001
From: Calcagiara <jacopocristoforitn@gmail.com>
Date: Wed, 30 Oct 2024 15:57:42 +0100
Subject: [PATCH] fix(kfp): fixed pods autorestart

---
 charts/kubeflow-pipelines/Chart.yaml                |  2 +-
 .../deployments/metadata-grpc-deployment.yaml       |  3 +++
 .../deployments/ml-pipeline-scheduledworkflow.yaml  |  1 +
 .../templates/deployments/ml-pipeline-ui.yaml       |  2 ++
 .../templates/deployments/ml-pipeline.yaml          |  3 +++
 .../templates/deployments/workflow-controller.yaml  |  2 ++
 .../templates/secrets/mlpipeline-s3-artifact.yaml   | 13 +++++++++++++
 7 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 charts/kubeflow-pipelines/templates/secrets/mlpipeline-s3-artifact.yaml

diff --git a/charts/kubeflow-pipelines/Chart.yaml b/charts/kubeflow-pipelines/Chart.yaml
index ac6e40d..d512bb9 100644
--- a/charts/kubeflow-pipelines/Chart.yaml
+++ b/charts/kubeflow-pipelines/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: kubeflow-pipelines
 description: A Helm chart for deploying Kubeflow Pipelines
 type: application
-version: 0.1.0
+version: 0.1.1
 maintainers:
   - name: ffais
     url: https://github.com/ffais
diff --git a/charts/kubeflow-pipelines/templates/deployments/metadata-grpc-deployment.yaml b/charts/kubeflow-pipelines/templates/deployments/metadata-grpc-deployment.yaml
index 2cdc3b1..4f6e100 100644
--- a/charts/kubeflow-pipelines/templates/deployments/metadata-grpc-deployment.yaml
+++ b/charts/kubeflow-pipelines/templates/deployments/metadata-grpc-deployment.yaml
@@ -13,6 +13,9 @@ spec:
       component: metadata-grpc-server
   template:
     metadata:
+      annotations:
+        checksum/config: {{ include (print $.Template.BasePath "/configmaps/pipeline-install-config.yaml") . | sha256sum }}
+        checksum/secret: {{ include (print $.Template.BasePath "/secrets/mysql-secret.yaml") . | sha256sum }}
       labels:
         application-crd-id: kubeflow-pipelines
         component: metadata-grpc-server
diff --git a/charts/kubeflow-pipelines/templates/deployments/ml-pipeline-scheduledworkflow.yaml b/charts/kubeflow-pipelines/templates/deployments/ml-pipeline-scheduledworkflow.yaml
index 176e47e..457172e 100644
--- a/charts/kubeflow-pipelines/templates/deployments/ml-pipeline-scheduledworkflow.yaml
+++ b/charts/kubeflow-pipelines/templates/deployments/ml-pipeline-scheduledworkflow.yaml
@@ -14,6 +14,7 @@ spec:
     metadata:
       annotations:
         cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
+        checksum/config: {{ include (print $.Template.BasePath "/configmaps/pipeline-install-config.yaml") . | sha256sum }}
       labels:
         app: ml-pipeline-scheduledworkflow
         application-crd-id: kubeflow-pipelines
diff --git a/charts/kubeflow-pipelines/templates/deployments/ml-pipeline-ui.yaml b/charts/kubeflow-pipelines/templates/deployments/ml-pipeline-ui.yaml
index 80bbc79..749f1c1 100644
--- a/charts/kubeflow-pipelines/templates/deployments/ml-pipeline-ui.yaml
+++ b/charts/kubeflow-pipelines/templates/deployments/ml-pipeline-ui.yaml
@@ -14,6 +14,8 @@ spec:
     metadata:
       annotations:
         cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
+        checksum/config: {{ include (print $.Template.BasePath "/configmaps/ml-pipeline-ui-configmap.yaml") . | sha256sum }}
+        checksum/secret: {{ include (print $.Template.BasePath "/secrets/mlpipeline-s3-artifact.yaml") . | sha256sum }}
       labels:
         app: ml-pipeline-ui
         application-crd-id: kubeflow-pipelines
diff --git a/charts/kubeflow-pipelines/templates/deployments/ml-pipeline.yaml b/charts/kubeflow-pipelines/templates/deployments/ml-pipeline.yaml
index 37580cb..5e08f6c 100644
--- a/charts/kubeflow-pipelines/templates/deployments/ml-pipeline.yaml
+++ b/charts/kubeflow-pipelines/templates/deployments/ml-pipeline.yaml
@@ -14,6 +14,9 @@ spec:
     metadata:
       annotations:
         cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
+        checksum/config: {{ include (print $.Template.BasePath "/configmaps/pipeline-install-config.yaml") . | sha256sum }}
+        checksum/config: {{ include (print $.Template.BasePath "/secrets/mysql-secret.yaml") . | sha256sum }}
+        checksum/config: {{ include (print $.Template.BasePath "/secrets/mlpipeline-s3-artifact.yaml") . | sha256sum }}
       labels:
         app: ml-pipeline
         application-crd-id: kubeflow-pipelines
diff --git a/charts/kubeflow-pipelines/templates/deployments/workflow-controller.yaml b/charts/kubeflow-pipelines/templates/deployments/workflow-controller.yaml
index f59106b..0408e96 100644
--- a/charts/kubeflow-pipelines/templates/deployments/workflow-controller.yaml
+++ b/charts/kubeflow-pipelines/templates/deployments/workflow-controller.yaml
@@ -13,6 +13,8 @@ spec:
       application-crd-id: kubeflow-pipelines
   template:
     metadata:
+      annotations:
+        checksum/config: {{ include (print $.Template.BasePath "/configmaps/workflow-controller-configmap.yaml") . | sha256sum }}
       labels:
         app: workflow-controller
         application-crd-id: kubeflow-pipelines
diff --git a/charts/kubeflow-pipelines/templates/secrets/mlpipeline-s3-artifact.yaml b/charts/kubeflow-pipelines/templates/secrets/mlpipeline-s3-artifact.yaml
new file mode 100644
index 0000000..ad02159
--- /dev/null
+++ b/charts/kubeflow-pipelines/templates/secrets/mlpipeline-s3-artifact.yaml
@@ -0,0 +1,13 @@
+{{- if not .Values.s3.externalSecret.secretName }}
+apiVersion: v1
+data:
+  accesskey: {{ .Values.s3.accessKey | b64enc | quote }}
+  secretkey: {{ .Values.s3.secretKey | b64enc | quote }}
+kind: Secret
+metadata:
+  annotations:
+  labels:
+    application-crd-id: kubeflow-pipelines
+  name: mlpipeline-s3-artifact
+type: Opaque
+{{- end }}