Fix copy of annotation on @main methods #22582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
reviewed
Feb 12, 2025
| val annots = mainFun.annotations | ||
| .filterNot(_.matches(defn.MainAnnot)) | ||
| .map(annot => insertTypeSplices.transform(annot.tree)) | ||
| .map(annot => TypedSplice(annot.tree)(using annotsCtx)) |
There was a problem hiding this comment.
IIUC, here the annotations are copied from the top-level method (mainFun) to the synthetic main method. Does the AST not need to be duplicated? Or does changeOwner in typedTypedSplice duplicate it?
There was a problem hiding this comment.
Or does
changeOwnerintypedTypedSpliceduplicate it?
Yes, the TypeTreeMap in changeOwner will copy the subtrees that differ. I think that should be enough?
lrytz
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22364.
See #13858 (comment).