Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Overrides #1057

Merged
merged 2 commits into from
Feb 25, 2025
Merged

RPC Overrides #1057

merged 2 commits into from
Feb 25, 2025

Conversation

carletex
Copy link
Member

Problem

Currently, changing the RPCs for the frontend is a bit tricky since SE-2 assumes that you are going to use Alchemy, and tweaking it requires you to tweak wagmiConfig and it's not very extract forward (we area bit vendor-locked with Alchemy)

Solution

Let the builders define the rpcOverrides in scaffold.config.ts. We don't want to pollute the config file, but RPC config seems like a top-level kind of config.

Tried to come up with the simplest way that respect the current functionality.

Really open!!

  • Should we do this?
  • Naming
  • Logic

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this?

Yes!

Naming
Logic

Lgtm! Added nit comments

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply love it! And we should totally add this! Thanks Carlos!!!

@carletex carletex marked this pull request as ready for review February 25, 2025 12:23
Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this Thanks all!

@technophile-04 technophile-04 merged commit 2fffd9e into main Feb 25, 2025
1 check passed
@technophile-04 technophile-04 deleted the rpc-overrides branch February 25, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants