Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version requirements on Readme #1052

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

Pabl0cks
Copy link
Collaborator

We just merged #1039 to add yarn ipfs using the new bgipfs package, but Windows users will have problems with SE-2 yarn install if they don't update to >20.18.1.

Changed required version to 20.18.3 on the Readme (closest lts version) so no users have problems with bgipfs package installation.

@rin-st
Copy link
Member

rin-st commented Feb 21, 2025

Hey Pablo, could you please also update main package.json engines?

@technophile-04
Copy link
Collaborator

technophile-04 commented Feb 21, 2025

Thanks Pablo!!


Ohh I think it would be nice to add the node version check in create-eth too like the CLI will exit directly if it finds the node version is less than our required.

Like the engines field already does that but does not work for everyone as I remember it was not respected for Damu here

@technophile-04 technophile-04 merged commit cee5fa6 into main Feb 21, 2025
1 check passed
@technophile-04 technophile-04 deleted the readme-node-version branch February 21, 2025 13:51
@carletex
Copy link
Member

Ohh I think it would be nice to add the node version check in create-eth too like the CLI will exit directly if it finds the node version is less than our required.

Yes! We talked about this before: scaffold-eth#162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants