Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round images of chapter manager #37

Open
kleinicke opened this issue Apr 24, 2022 · 1 comment
Open

Round images of chapter manager #37

kleinicke opened this issue Apr 24, 2022 · 1 comment
Labels
design Design choices

Comments

@kleinicke
Copy link
Member

The images of the chapter manager should always be displayed as a circle. Currently, the images are shown as an oval, when the uploaded image is not a perfect square.
So before rendering, the image should be internally cropped to a square.

@kleinicke kleinicke changed the title Round images Round images of chapter manager Apr 24, 2022
@janosh
Copy link
Member

janosh commented May 8, 2022

There's no clean on-the-fly solution. We'd have to use wrapper divs or change how we handle the data for our chapter pages in Contentful. If we fetched the images directly instead of through markdown, we could use Contentful's Images API which has cropping functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design choices
Projects
None yet
Development

No branches or pull requests

3 participants