Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pcall protection #123

Merged
merged 13 commits into from
Oct 15, 2024
Merged

Feature/pcall protection #123

merged 13 commits into from
Oct 15, 2024

Conversation

sbrl
Copy link
Owner

@sbrl sbrl commented Oct 12, 2024

This is a WIP PR to implement pcall/xpcall-style protection when running commands for #115. This is significantly more complicated than you think, so this PR is a draft until I'm done.

Still to do:

  • Implement our own encodeURIComponent() cause the one I lifted from SO sucks
  • Try out coroutines (aka like Wren Fibres: https://wren.io/concurrency.html) because we might be able to lift the stack trace like this
  • Tidy up the test implementation so it can be repeated more easily - maybe something like weac.safe_function() to complement safe_region?
  • Finally, apply the approach across the rest of the codebase.

sbrl added 9 commits October 12, 2024 01:04
@sbrl
start working on implementing some kind of system to catch error mess…
cd22c71 
…ages

....it works, but:
- We can't capture stack traces like this
- It's messy
- We need to implement an escape/encodeURIComponent function ourselves from scratch 'cause the one I ripped from Stack Overflow sucks
@sbrl
//count: deliberately introduce a crash for testing purposes
39b3ef4 
YOU DO NOT WANT THIS COMMIT!
TODO REVERT THIS COMMIT VIA REBASE WHEN DONE.
@sbrl
run_command: add prototype wrapper around command parsing.
938a617
@sbrl
newline
c01eb23
@sbrl
abstract new xpcall wrapper into new API function safe_function
00b1aed
@sbrl
core: tidy up new safe_function implementation; bugfix
b6c4139
@sbrl
safe_function: only log error when there's actually an error
ea1c17a
@sbrl
//maze, //maze3d: update to WEA pos API
4bd278d 
Ref https://worldeditadditions.mooncarrot.space/api/#worldeditadditions_core.pos
@sbrl
Revert "//count: deliberately introduce a crash for testing purposes"
e0ba5d9 
This reverts commit 39b3ef4.
@sbrl sbrl marked this pull request as ready for review October 14, 2024 19:56
@sbrl sbrl merged commit 57d09a7 into dev Oct 15, 2024
2 of 3 checks passed
@sbrl sbrl deleted the feature/pcall-protection branch October 15, 2024 19:15
@sbrl sbrl mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sbrl