Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
core.param2: add todo reimplement notice
Ref https://discord.com/channels/1135598362821935254/1247681375935533119 --------------------------------------- Hi, a wild //orient+ appeared! While it (probably) doesn't crash, it also unfortunately doesn't work yet. This is because facedir e.g. points towards the direction the node is pointing, and minetest.facedir_to_dir doesn't capture all the nuance of how the node is pointing, and e.g. if a node is pointing +y and you want to rotate by (0, 90, 0) [degrees], then the current implementation won't do anything. Then I decided that this is silly and there has to be a solution. After all, screwdriver2 has a great implementation! https://content.minetest.net/packages/12Me21/screwdriver2/ ....then I found this lookup table in their codebase: https://github.com/12Me21/screwdriver2/blob/master/init.lua#L75-L79 ....aaaaarrrggggghhhhh //orient+ is such a pain to implement! and my existing implementation is so neat 😢 https://github.com/sbrl/Minetest-WorldEditAdditions/blob/1dd073f14bcac8e26a5ced2abe54c709099b1de2/worldeditadditions_core/utils/param2.lua so, in other words, although I've implemented //orient+ I'm going to have to reimplement the nuts-and-bolts function that does the rotation, which may make it slightly more complicated and annoying to implement support for nodes with param2 types other than facedir. /rant about Minetest's param2 value and rotations 😛
- Loading branch information