Skip to content

Deprecate config parameters for the new logging #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sblauth opened this issue Oct 16, 2024 · 1 comment
Open

Deprecate config parameters for the new logging #506

sblauth opened this issue Oct 16, 2024 · 1 comment
Assignees
Labels
config Issues and PRs concerning cashocs configuration
Milestone

Comments

@sblauth
Copy link
Owner

sblauth commented Oct 16, 2024

With the new logging capabilities, the parameters

[Output]
verbose
save_txt

will be obsolte, as well as the FileManager for outputting the history of the optimization with the save_txt parameter. These should be removed.

Additionally, most of the places where a "verbose" parameter is used to control the output, this should be replaced by logging.

@sblauth sblauth added enhancement New feature or request config Issues and PRs concerning cashocs configuration labels Oct 16, 2024
@sblauth sblauth self-assigned this Oct 16, 2024
@sblauth sblauth removed the enhancement New feature or request label Oct 16, 2024
@sblauth
Copy link
Owner Author

sblauth commented Oct 16, 2024

Configuration Parameters that are deprecated

Section StateSystem

  • picard_verbose
  • newton_verbose

Section Output

  • verbose

Function paramters that are deprecated

  • cashocs.nonlinear_solvers.newton_solve - verbose
  • cashocs.nonlinear_solvers.picard_iteration - verbose
  • cashocs.space_mapping.solve - verbose
  • cashocs.space_mapping.solve - save_history

These parts should be accessed as part of the logging module

  • cashocs.set_log_level -> cashocs.log.set_log_level
  • cashocs.LogLevel.INFO -> cashocs.log.INFO (and analogously for the other levels)

@sblauth sblauth added this to the v3.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Issues and PRs concerning cashocs configuration
Projects
None yet
Development

No branches or pull requests

1 participant