fix: two fixes around native display output #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winit+x11 usually supplies a single redraw event where the window’s backing buffer is still size zero. ignoring this case stops the event handler thread from panicking.
physical size is needed since our raw framebuffer work doesn’t care about logical pixels and associated DPI scaling. with logical size, the window is too large (or even too small) for the area that is actually used for the framebuffer.
|
Many thanks for your fixes and the detailed explanation! |
Merged
|
And released as 0.16.2, thanks again! Congrats on the PR number btw :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ignore spurious zero-sized window buffers
winit+x11 usually supplies a single redraw event where the window’s backing buffer is still size zero. ignoring this case stops the event handler thread from panicking.
fix: use physical size for winit window
physical size is needed since our raw framebuffer work doesn’t care about logical pixels and associated DPI scaling. with logical size, the window is too large (or even too small) for the area that is actually used for the framebuffer.