refactor!: Decouple breakwater-parser to make it easier to integrate elsewhere #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
force-pushed
the
decouple-parser-review
branch
from
cf12b2d to
b1eaf1a
Compare
sbernauer
force-pushed
the
decouple-parser-review
branch
from
b1eaf1a to
223fd67
Compare
sbernauer
changed the title
|
Merging this, as I would like to add an native window mode. For this I would like to use the Trait added here to not get merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative take on #35.
This pull request hides breakwaters framebuffer implementation behind a trait. This allows other project to use the breakwater magic but implement their own framebuffer.
These change do not introduce dynamic dispatch so runtime performance should™ not be affected.
Co-authored-by: bits0rcerer 25325997+bits0rcerer@users.noreply.github.com