Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump game-ci/unity-builder from 2 to 4 #219

Merged
merged 1 commit into from
May 9, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 17, 2023

Bumps game-ci/unity-builder from 2 to 4.

Release notes

Sourced from game-ci/unity-builder's releases.

Windows Improvements and QOL Additions

This release bumps docker images for Windows to Server 2022 in anticipation of Server 2019 EOL. It is highly recommended for users to upgrade to this version as it contains a security fix for personal license serial masking as well as major stability and QOL fixes and improvements.

What's Changed

  • [Breaking] Windows images upgraded to Server 2022. This means you must update your workflows to use windows-2022 or ensure self-hosted runners are running Windows Server 2022 or Windows 11 or the images will fail to start
  • [Breaking] Updated license activation method to fix increased license activation failures. Personal license activation on Linux now requires UNITY_EMAIL and UNITY_PASSWORD to be passed in addition to UNITY_LICENSE. Look at our License Activation Docs for more guidance.
  • Fix serial number leak for personal license activation. This only affects users who only provide a license file for personal activation. Professional serials are not affected. Furthermore, serial numbers require username and password to activate so the risk of malicious use is low. Regardless it is highly recommended to update to v4 to ensure proper masking and for extra security, delete any unexpired build logs.
  • Windows now properly uses exit codes for determining build failures. This should bring it in line with Ubuntu behavior and fix several issues introduced by v3. Parsing for error count is now disabled
  • Fixes for Windows builds hanging on exit
  • Add annotations to default build script so Unity warnings and errors become github annotations to make debugging builds easier. For custom build methods, you can add this CompileListener script to your editor folder to gain the same functionality
  • Add containerRegistryRepository and containerRegistryImageVersion fields to allow easier use of custom images and the ability to roll back image versions
  • Add dockerCpuLimit, dockerMemoryLimit, and dockerIsolationMode for improved container performance control. Windows containers will by default now use more available system resources to improve build performance. Previously they were stuck at 1 cpu and 1GB memory due to a docker bug
  • Building on MacOS no longer requires sudo as long as the license activation path /Library/Application Support/Unity exists
  • MacOS setup now installs the correct architecture of Unity to account for Apple Silicon runners by @​dcvz in game-ci/unity-builder#591
  • manualExit suppresses -quit, useful for buildMethods with async calls by @​tobyspark in game-ci/unity-builder#574
  • fix android sdkmanager invocation by @​eronnen in game-ci/unity-builder#582

New Contributors

Full Changelog: game-ci/unity-builder@v3...v4.0.0

Allow multiple SSH keys

What's Changed

See https://game.ci/docs/github/builder#sshpublickeysdirectorypath

New Contributors

Full Changelog: game-ci/unity-builder@v3...v3.1.0

Use improved next generation images (v2.x)

What's Changed

... (truncated)

Commits
  • 8da77ac Ensure blank project files can be deleted by github runner (#599)
  • 2afd9cd Additional Fixes and Improvements (#596)
  • caa0a81 License Activation fixes and Github Annotations (#590)
  • 7afabe7 Additional Windows Image Updates (#589)
  • 4c4611c Feature/windows upgrades (#588)
  • 6419c87 fix android sdkmanager invocation (#582)
  • a13443a manualExit suppresses -quit, useful for buildMethods with async calls (#574)
  • 2190fd5 Support multiple GitHub SSH deploy keys (#568)
  • a073719 BREAKING (potentially) - Bump docker version (Ubuntu 22.04 LTS) (#556)
  • ff551fe Fix versions (#559)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @sbergen.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d706eed) to head (86f324d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #219   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         2129      2129           
  Branches       109       109           
=========================================
  Hits          2129      2129           
Flag Coverage Δ
Unity2021.3.27f1 ?
Unity2022.3.2f1 100.00% <ø> (ø)
netstandard 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbergen
Copy link
Owner

sbergen commented May 9, 2024

@dependabot rebase

@sbergen sbergen added the Skip-Changelog Skips CHANGELOG.md check if not needed label May 9, 2024
@dependabot dependabot bot force-pushed the dependabot/github_actions/game-ci/unity-builder-4 branch from c8b1a8b to bdab892 Compare May 9, 2024 16:43
@sbergen
Copy link
Owner

sbergen commented May 9, 2024

@dependabot rebase

Bumps [game-ci/unity-builder](https://github.com/game-ci/unity-builder) from 2 to 4.
- [Release notes](https://github.com/game-ci/unity-builder/releases)
- [Commits](game-ci/unity-builder@v2...v4)

---
updated-dependencies:
- dependency-name: game-ci/unity-builder
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/game-ci/unity-builder-4 branch from bdab892 to 86f324d Compare May 9, 2024 17:10
@sbergen
Copy link
Owner

sbergen commented May 9, 2024

@dependabot merge

@dependabot dependabot bot merged commit eff1442 into main May 9, 2024
14 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/game-ci/unity-builder-4 branch May 9, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code Skip-Changelog Skips CHANGELOG.md check if not needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant