Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting for Github #392

Open
mneumann opened this issue Sep 19, 2022 · 2 comments
Open

Syntax highlighting for Github #392

mneumann opened this issue Sep 19, 2022 · 2 comments
Labels
BLOCKED We can't or shouldn't work on this yet, for reasons explained in the ticket and/or comments. complexity 1: simple This should be quite easy to pull off. kind: feature: tooling Adding new tooling or a new feature in existing tooling

Comments

@mneumann
Copy link
Contributor

Would be nice to see .savi file in color on Github :)

Github uses Linguist:

https://github.com/github/linguist/

to determine which syntax highlighter to use for a file. If we have an appropriate syntax highlighter, open up a pull request to Linguist to support Savi.
@mneumann mneumann added complexity 1: simple This should be quite easy to pull off. kind: feature: tooling Adding new tooling or a new feature in existing tooling labels Sep 19, 2022
@jemc
Copy link
Contributor

jemc commented Sep 19, 2022 •
edited
Loading

I would have done this long ago, but GitHub requires a certain number of repositories using that language before they will accept a language matcher for it.

See their docs here: https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-a-language

I would love to get this ASAP but due to those restrictions, I think we have to consider this ticket as blocked.

@jemc jemc added the BLOCKED We can't or shouldn't work on this yet, for reasons explained in the ticket and/or comments. label Sep 19, 2022
@mneumann
Copy link
Contributor Author

So, 200 is our goal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BLOCKED We can't or shouldn't work on this yet, for reasons explained in the ticket and/or comments. complexity 1: simple This should be quite easy to pull off. kind: feature: tooling Adding new tooling or a new feature in existing tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mneumann @jemc