Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix the CI failures on packaging > 22 #115

Merged
merged 6 commits into from
Jan 31, 2023
Merged

CI: fix the CI failures on packaging > 22 #115

merged 6 commits into from
Jan 31, 2023

Conversation

frostming
Copy link
Member

@frostming frostming commented Jan 13, 2023

Because there are test cases against indexes for other languages and their version don't follow the python standards, we have to set version cap of packaging to <22.0 for testing.

Also, switch to nox in CI workflows.


Fixes #114

@frostming
Copy link
Member Author

Python 2.7 is failing due to incompatible nox. Since we are going to drop 2.7(#116) I prefer to remove it from the matrix.

@kitterma
Copy link

What's the solution for those that don't have the option to stay with the old version?

@frostming
Copy link
Member Author

What's the solution for those that don't have the option to stay with the old version?

That is the test dependency and resolvelib itself doesn't have any dependency

@kitterma
Copy link

kitterma commented Jan 13, 2023 via email

@uranusjr
Copy link
Member

The Swift tests actually implement a hand-rolled extremely simplified parser, perhaps we could do the same? https://github.com/sarugaku/resolvelib/blob/master/tests/functional/swift-package-manager/test_resolvers_swift.py

@frostming frostming requested a review from uranusjr January 31, 2023 03:17
@frostming frostming changed the title CI: fix the CI failures by set version cap for packaging CI: fix the CI failures on packaging > 22 Jan 31, 2023
setup.cfg Show resolved Hide resolved
@uranusjr uranusjr merged commit f678825 into main Jan 31, 2023
@uranusjr uranusjr deleted the ci/nox branch January 31, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failures With Packaging 22.0/23.0
3 participants