Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commitment renewal endpoint #674

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add commitment renewal endpoint #674

wants to merge 8 commits into from

Conversation

VoigtS
Copy link
Member

@VoigtS VoigtS commented Mar 4, 2025

This endpoint aims to make commitments renewable if they are within the allowed renewal timeframe.

Current issue is that the commitment that was renewed owns a was_extended state, but does not carry the successor ID yet. That begs the question if the state itself should contain it or if it should be handled by the superseded context.
That on the other hand would require to either set the commitment as superseded when the commitment is ultimately marked as expired or if just the superseded Context is considered in this circumstance.

I change this to a regular PR now due to (maybe upcoming urgency about this topic?), it has to be noted that the UI expects was_extended from the get commitments API in order to not list already renewed commitments.

TODO's:

  • I updated the documentation to describe the semantical or interface changes I introduced.

@coveralls
Copy link

coveralls commented Mar 4, 2025

Coverage Status

coverage: 79.457% (+0.03%) from 79.426%
when pulling 3d0d11f on renew
into 94a2002 on master.

@VoigtS
Copy link
Member Author

VoigtS commented Mar 11, 2025

UI draft: sapcc/LimesUI#36
API declarations: sapcc/go-api-declarations#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants