Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint aims to make commitments renewable if they are within the allowed renewal timeframe.
Current issue is that the commitment that was renewed owns a
was_extended
state, but does not carry the successor ID yet. That begs the question if the state itself should contain it or if it should be handled by thesuperseded
context.That on the other hand would require to either set the commitment as
superseded
when the commitment is ultimately marked asexpired
or if just thesuperseded Context
is considered in this circumstance.I change this to a regular PR now due to (maybe upcoming urgency about this topic?), it has to be noted that the UI expects
was_extended
from theget commitments
API in order to not list already renewed commitments.TODO's: