From 8540f8dd921a5b9dbef4a133aa9333014c5720af Mon Sep 17 00:00:00 2001 From: Sancarn Date: Fri, 26 Apr 2024 12:18:13 +0100 Subject: [PATCH] Closes #95 Remove undefined variables `User` and `Pass` from `LoadAutoProxy`. TODO: Check if there are any situations where these credentials are needed. --- changelog.md | 1 + src/stdHTTP.cls | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/changelog.md b/changelog.md index dbb4232..89e02a3 100644 --- a/changelog.md +++ b/changelog.md @@ -273,3 +273,4 @@ Before `08/07/2021` a change log was not kept. We have retrospectively gone back - 2024-04-08 `stdWindow` FEATURE - Added `isCaptionVisible`,`isBorderVisible`,`isMaximiseButtonVisible`,`isMinimiseButtonVisible`,`isSystemMenuVisible`,`isVerticalScrollbarVisible`,`isHorizontalScrollbarVisible`,`isChildWindow`,`isPopupWindow`,`isAppWindow`,`isToolWindow`,`isClickThroughEnabled`,`isBorderEdgeSunken`,`isBorderDoubled`,`isLayeredWindow`,`LayeredWindowFlags`,`LayeredWindowChromaKey`,`LayeredWindowOpacity` flag setters. - 2024-04-22 `stdJSON` FEATURE - Added `ChildrenInfo` which returns a Collection of dictionaries containing info about the children. Used in stdVBA-examples JSON viewer. - 2024-04-22 `stdWindow` BREAKING - Renamed `LayeredWindowOpacity` to `Opacity` and `LayeredWindowChromaKey` to `TransparentColor`. If these are called then `isLayeredWindow` will be automatically set to `true`. +- 2024-04-26 `stdHTTP` FIX - Remove undefined variables `User` and `Pass` from `LoadAutoProxy`. TODO: Check if there are any situations where these credentials are needed. diff --git a/src/stdHTTP.cls b/src/stdHTTP.cls index 501fcf5..d7464ac 100644 --- a/src/stdHTTP.cls +++ b/src/stdHTTP.cls @@ -520,8 +520,8 @@ Private Sub LoadAutoProxy(ByVal sURL as string, ByVal oProxy as Object) oProxy("hasProxy") = true oProxy("server") = info.ProxyServer oProxy("bypass") = info.ProxyBypass - oProxy("user") = user - oProxy("pass") = pass + oProxy("user") = Empty 'TODO: Check if user/pass credentials with auto-proxy will ever be needed + oProxy("pass") = Empty else if info.Error.isRecoverable then 'Assume no proxy