Skip to content

Commit

Permalink
Closes #95
Browse files Browse the repository at this point in the history
Remove undefined variables `User` and `Pass` from `LoadAutoProxy`. TODO: Check if there are any situations where these credentials are needed.
  • Loading branch information
sancarn committed Apr 26, 2024
1 parent 91ec69f commit 8540f8d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -273,3 +273,4 @@ Before `08/07/2021` a change log was not kept. We have retrospectively gone back
- 2024-04-08 `stdWindow` FEATURE - Added `isCaptionVisible`,`isBorderVisible`,`isMaximiseButtonVisible`,`isMinimiseButtonVisible`,`isSystemMenuVisible`,`isVerticalScrollbarVisible`,`isHorizontalScrollbarVisible`,`isChildWindow`,`isPopupWindow`,`isAppWindow`,`isToolWindow`,`isClickThroughEnabled`,`isBorderEdgeSunken`,`isBorderDoubled`,`isLayeredWindow`,`LayeredWindowFlags`,`LayeredWindowChromaKey`,`LayeredWindowOpacity` flag setters.
- 2024-04-22 `stdJSON` FEATURE - Added `ChildrenInfo` which returns a Collection of dictionaries containing info about the children. Used in stdVBA-examples JSON viewer.
- 2024-04-22 `stdWindow` BREAKING - Renamed `LayeredWindowOpacity` to `Opacity` and `LayeredWindowChromaKey` to `TransparentColor`. If these are called then `isLayeredWindow` will be automatically set to `true`.
- 2024-04-26 `stdHTTP` FIX - Remove undefined variables `User` and `Pass` from `LoadAutoProxy`. TODO: Check if there are any situations where these credentials are needed.
4 changes: 2 additions & 2 deletions src/stdHTTP.cls
Original file line number Diff line number Diff line change
Expand Up @@ -520,8 +520,8 @@ Private Sub LoadAutoProxy(ByVal sURL as string, ByVal oProxy as Object)
oProxy("hasProxy") = true
oProxy("server") = info.ProxyServer
oProxy("bypass") = info.ProxyBypass
oProxy("user") = user
oProxy("pass") = pass
oProxy("user") = Empty 'TODO: Check if user/pass credentials with auto-proxy will ever be needed
oProxy("pass") = Empty
else
if info.Error.isRecoverable then
'Assume no proxy
Expand Down

0 comments on commit 8540f8d

Please sign in to comment.