Bulkrax editing without model #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing via a CSV, if the model was omitted or incorrect, bulkrax had been creating a new new object instead of updating the existing one. This resulted in two Valkyrie resources with only the new one being indexed. This fix updates the `find_by_source_identifier` method (via `find_by_property_value`) to now find without using the model, to ensure that we find the existing record. It also updates the importer view to display the actual model rather than finding so the displayed model will be correct since may not always be present in the CSV.
laritakr
force-pushed
the
bulkrax-editing-without-model
branch
from
b0d8d79 to
8a18fef
Compare
orangewolf
approved these changes
Apr 4, 2025
There's still apparently some sort of bug due to slugs so I had to move it back to draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1024
This commit allows a CSV importer edit to find the object to edit by the identifier rather than requiring the class.
Behavior before change
If a CSV did not include the model, the edit would create new valkyrie works using the defined default model. This resulted in two works in the resource table, with only the newer one indexed. The new work would only contain the metadata present in the edit CSV. The prior work was left untouched.
Behavior after change
The source identifier alone is adequate to find the object to edit, and the importer view shows the correct model name when it links to the edited object.
(Note that it still shows the default type above the raw and parsed metadata)
Screenshot