Improve compatibility with Read the Dokus template #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add data-wiki-id attribute that is used by DokuWiki "Read the Dokus" template to navigate between pages.
|
Did you test this also with the new js tree added recently? The old js tree is deprecated, so will be removed at certain point.. Line 236 in 3a7b842 That new tree is built by js with data from ajax, so no idea whether it works together with what that template tries to achieve. |
|
I didn’t tested it yet, but I believe this not only benefits this template, but it’s a common behavior for inter wiki links (DokuWiki appends this attribute by default for inter wiki links). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data-wiki-id attribute that is used by DokuWiki "Read the Dokus" template to navigate between pages.