Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tweakpane peer dependency to support version 4.x #5

Open
lifeinchords opened this issue Sep 29, 2024 · 3 comments
Open

Update Tweakpane peer dependency to support version 4.x #5

lifeinchords opened this issue Sep 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@lifeinchords
Copy link

hey @samme !

I'm currently using phaser-plugin-inspector in a project where we've upgraded to Tweakpane 4.0.4. However, the current peer dependency in phaser-plugin-inspector is set to "tweakpane": "^3.1.0", which is causing conflicts in our dependency resolution.

Could you please consider updating the peer dependency to include Tweakpane 4.x? This would allow users to take advantage of the latest features and improvements in Tweakpane while still using phaser-plugin-inspector.

Thank you for all your help with Phaser

@samme samme added the enhancement New feature or request label Sep 29, 2024
@samme
Copy link
Owner

samme commented Sep 29, 2024

Hi, thanks. I think I see some challenges with this:

  • Need to rewrite ~244 monitors to use addBinding() etc. Maybe Copilot can help.
  • Tweakpane v4 has no global so it would be impossible to use the Quick load snippet (for Labs or the Sandbox) or the Load from console snippet.
  • I'm not sure how the plugin could access Tweakpane in the browser without adding an import map or globalizing Tweakpane's exports. I guess the plugin could bundle Tweakpane instead.

@lifeinchords
Copy link
Author

Thanks for the detailed reply..that sounds like a fair bit of work, I thought it might be an easy change.

I took a different direction in the meantime with another stack.. hope to hop back on this proj soon

@samme
Copy link
Owner

samme commented Oct 14, 2024

I think the method changes are doable somehow. But I think I would have to bundle Tweakpane to keep the plugin loadable like people are used to, and that might be a little worse for your situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants