Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag features on test data #2

Open
CallmeAmmo opened this issue Sep 1, 2023 · 0 comments
Open

Lag features on test data #2

CallmeAmmo opened this issue Sep 1, 2023 · 0 comments

Comments

@CallmeAmmo
Copy link

Hi , went through your code. But i find one problem over hear , you have created lag features first and then you have split the data into training and testing . Doesn't it count as data leak as for the unseen data you would not have sales for all the unseen day then there this creation of lag would become a problem. Can you help with this and how could you create lag for the upcoming days for prediction as there are important features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant