ADD playdate.system.setMenuImage() #101
Merged
+72
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the memory tracer reporting calls to deallocate unmanaged memory
This was causing an error in GCC 14 related to incompatible pointer types -- 'void (*)(char *, ...)' instead of 'void (* const)(const char *, ...)'
# Conflicts: # src/playdate/graphics.nim
# Conflicts: # src/playdate/graphics.nim
ninovanhooff
commented
Feb 13, 2025
ninovanhooff
commented
Feb 13, 2025
ninovanhooff
commented
Feb 14, 2025
ninovanhooff
commented
Feb 14, 2025
Because system can now be imported without dependency cycles again
ninovanhooff
force-pushed
the
setMenuImagerefactor
branch
from
7c406d1 to
037b6ec
Compare
Nycto
reviewed
Feb 15, 2025
src/playdate/system.nim
Outdated
| @@ -6,6 +6,7 @@ import sequtils | |||
|
|
|||
| import bindings/[api, types] | |||
| import bindings/system | |||
| import domain/lcdbitmap {.all.} | |||
There was a problem hiding this comment.
Can you use privateAccess instead of all?
There was a problem hiding this comment.
That seems not to work for fields, possibly only for procs
(I'm using it to access LCDBItmap.resource)
ninovanhooff
commented
Feb 16, 2025
Nycto
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a refactor of lcdbtmap out of graphics.nim
It's a bit painful with the blunt visibility modifiers of Nim (404 on the internal keyword here),
I put it in domain/lcdbitmap.nim for now.
I need this separation because I added playdate.system.setMenuImage(), which takes an LCDBitmap and I don't want system to depend on graphics. Doing that would lead to the awkward situation where you can use logToConsole anymore in graphocs.nim (cyclic dependency). So now, system and graphics can both depend on lcdbitmap instead.
I'm very much open to suggestions on this one.
Regarding the commits: Github seems to not have caught up to the merge of the bin branch, or history got rewritten. I can squash merge this to muddy up the history