Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add a maintenance status warning #351

Merged
merged 1 commit into from
Dec 3, 2024
Merged

readme: add a maintenance status warning #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

An operator for Samba as a service on PVCs in kubernetes.

## ⚠️ Maintenance Status ⚠️

Maintainers and contributors wanted!

We wish to thank everyone who has shown interest in using and/or contributing to the samba-operator! However, we feel it important to share the fact that samba-operator is now minimally maintained. This means that the current team tries to keep up with basic "housekeeping" tasks but has little to no time for working on features or even some non-critial bug fixes. This is at least partly due to changing priorities for our employer - and since most of us work on this project as $DAYJOB task we don't have as much time to spend on this operator.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 'is':
"...we feel it is important..."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serves me right for trying to do this quickly using the GH UI, now I need to figure out how to edit a commit. :-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phlogistonjohn qrote:

Serves me right for trying to do this quickly using the GH UI,

Well, the obvious advantage of that is the immediate visual control of the ewndered document.

now I need to figure out how to edit a commit. :-)

I don't know if it is possible in the UI at all.

Of course you know this, but you can do it locally with git commit --amend

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One alternative: If the change request is added as a suggested diff, you can apply it as an additional commitfrom the GH UI, but then it would need to be squashed with your original commit and I think that is not possible from the UI but has to be done locally with git rebase -i

So as a summary, I think it is not possible yo do it entirely from the UI, only partially.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phlogistonjohn , we could also fix this in a follow-up PR :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #352


We'd like this to be otherwise and as such we highly encourange anyone with a basic knowledge of Kubernetes, Go, or Operators who wants to see a healthy samba-operator consider getting involved. Feel free to contact the team via the [GitHub discsussions for the project](https://github.com/samba-in-kubernetes/samba-operator/discussions).

## Description

This project implements the samba-operator. It it responsible for the
Expand Down
Loading