Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add a maintenance status warning #351

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

phlogistonjohn
Copy link
Collaborator

Add a maintenance alert section to the readme. Ask for maintainers and contributors.

Signed-off-by: John Mulligan <33039589+phlogistonjohn@users.noreply.github.com>
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (+minor comment)


Maintainers and contributors wanted!

We wish to thank everyone who has shown interest in using and/or contributing to the samba-operator! However, we feel it important to share the fact that samba-operator is now minimally maintained. This means that the current team tries to keep up with basic "housekeeping" tasks but has little to no time for working on features or even some non-critial bug fixes. This is at least partly due to changing priorities for our employer - and since most of us work on this project as $DAYJOB task we don't have as much time to spend on this operator.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 'is':
"...we feel it is important..."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serves me right for trying to do this quickly using the GH UI, now I need to figure out how to edit a commit. :-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phlogistonjohn qrote:

Serves me right for trying to do this quickly using the GH UI,

Well, the obvious advantage of that is the immediate visual control of the ewndered document.

now I need to figure out how to edit a commit. :-)

I don't know if it is possible in the UI at all.

Of course you know this, but you can do it locally with git commit --amend

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One alternative: If the change request is added as a suggested diff, you can apply it as an additional commitfrom the GH UI, but then it would need to be squashed with your original commit and I think that is not possible from the UI but has to be done locally with git rebase -i

So as a summary, I think it is not possible yo do it entirely from the UI, only partially.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phlogistonjohn , we could also fix this in a follow-up PR :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #352

Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, but I agree to the missing is that @synarete spotted.

Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made up my mind: we can change that one thing in a follow-up PR.
LGTM.

@mergify mergify bot merged commit 53b3fd4 into master Dec 3, 2024
13 checks passed
obnoxxx added a commit to obnoxxx/samba-operator that referenced this pull request Dec 3, 2024
This addresses one issue found in the review of this PR:
samba-in-kubernetes#351

Signed-off-by: Michael Adam <obnox@samba.org>
@obnoxxx obnoxxx mentioned this pull request Dec 3, 2024
obnoxxx added a commit to obnoxxx/samba-operator that referenced this pull request Dec 3, 2024
This addresses one issue found in the review of this PR:
samba-in-kubernetes#351

samba-in-kubernetes#351 (comment)

Signed-off-by: Michael Adam <obnox@samba.org>
mergify bot pushed a commit that referenced this pull request Dec 4, 2024
This addresses one issue found in the review of this PR:
#351

#351 (comment)

Signed-off-by: Michael Adam <obnox@samba.org>
@mergify mergify bot added the priority-review This PR deserves a look label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-review This PR deserves a look
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants