-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(map and defaults): Update the map.jinja file and add yaml maps #134
Conversation
This changes the map.jinja file to be more like the standard template. It also adds defaults, osfamlymap, osfingermap, and osmap yaml files for easy mapping of the proper packages and settings for each OS and version of the OS.
@absmith82 Thanks for starting this, it's a very useful PR. An initial comment: all of these files need to be moved to the |
You are right, Sorry I was careless and just uploaded the files to the wrong place after testing on my test server. I'll check the readme and reformat the commit message and fix the file structure. Thanks |
@absmith82 I've run some tests to compare the map that is produced before and after this PR. The results need to be identical for a successful conversion. I've been able to fix things at my end, so I'll append a commit to this PR in a little while, so that you can look over the changes made. Once we're happy with that, we can squash the whole PR to fix the commit message, so that we get |
Thanks for the update. I've been looking at the Travis ci tests and it
looks like the tests are failing because of repo issues. But any updates
to make it the same as before would be fine with me. I literally just the
old map.jinja values and translated then into the different yaml map files
I may have changed the postgres packages due to the old ones being virtual
packages.
…On Sat, Mar 21, 2020, 1:09 PM Imran Iqbal ***@***.***> wrote:
@absmith82 <https://github.com/absmith82> I've run some tests to compare
the map that is produced before and after this PR. The results need to be
identical for a successful conversion. I've been able to fix things at my
end, so I'll append a commit to this PR in a little while, so that you can
look over the changes made. Once we're happy with that, we can squash the
whole PR to fix the commit message, so that we get semantic-release
working -- changing the title of the PR isn't enough, unfortunately.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#134 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJCDLA5K2CIIWU6R224KF3RIUGHLANCNFSM4LQVS52Q>
.
|
* Avoid issues with template: - `[ERROR ] Unable to manage file: Jinja variable 'tpldir' is undefined`
Issues@absmith82 It's easiest to cover the situation by looking at the diffs. For all of the diffs, due to the nature of how I was generating the changes, anything with a minus (
ResolutionSee 3d324d9...b7c0977 for the changes that have been added to this PR.
ResultAll of the platforms are now passing: Remaining stepsAfter confirming the changes, the commits need to be fixed so that |
@absmith82 So just to confirm, all of the platforms are passing for this PR: The only thing remaining is the |
I have no problems with the changes you made. Most were formatting mistakes I made so if you can squash the commit to fix the commitlint test that would be great. |
Thanks @absmith82, merged and released successfully: |
@absmith82 One more thing, you may want to send through a PR regarding the |
@absmith82 Just got reminded that #123 already contains the suggestion for updating all of the platforms to |
This changes the map.jinja file to be more like the standard template. It also adds defaults, osfamlymap, osfingermap, and osmap yaml files for easy mapping of the proper packages and settings for each OS and version of the OS.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context